Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Unsampled Transactions to reduce memory pressure #3972

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamescrosswell
Copy link
Collaborator

WIP... really needs to be done after #3951 gets merged as it's fiddling with the same sections of code (and needs to take into account the sample_rand etc. as well).

Not sure if this is worth finishing since we eventually plan to get rid of transactions entirely.

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Unsampled Transactions to reduce memory pressure ([#3972](https://github.com/getsentry/sentry-dotnet/pull/3972))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against dd0451c

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern I have is; Does this affect our ability to create and propagate trace ids downstream? or to continue a trace (on aspnetcore) if a transaction wasn't sampled?

@jamescrosswell
Copy link
Collaborator Author

One concern I have is; Does this affect our ability to create and propagate trace ids downstream? or to continue a trace (on aspnetcore) if a transaction wasn't sampled?

I don't think so no... I thought about that when creating the UnsampledTransaction class (making sure trace propagation still works). Some further testing could be done to double/triple check this.

I guess it's lots of questions like this that make me a bit nervous - it's the sort of change that really requires thorough testing before rolling it out. In an ideal world, that would all be covered by unit tests, but I'm not sure that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants