-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for mixed SDK versions #4270
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Check for mixed SDK versions ([#4270](https://github.com/getsentry/sentry-java/pull/4270)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for (SentryPackage pkg : packages) { | ||
if (pkg.getName().startsWith("maven:io.sentry:") | ||
&& !sdkVersion.equalsIgnoreCase(pkg.getVersion())) { | ||
logger.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we should introduce a method that force-logs regardless of the debug and diagnosticLevel values set and use it here, wdyt?
📜 Description
SentryIntegrationPackageStorage.packages
for mixed versions when sending out an envelope.This is only the first step where we log when mixed versions have been detected.
Next step is to not enable the SDK in that case.
💡 Motivation and Context
First step for solving #4132
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps