Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate set_measurement() API. #3934

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jan 14, 2025

Deprecate set_measurement(). This will be replaced by set_data() which internally is using the Otel set_attribute().

Fixes #3074

Copy link

codecov bot commented Jan 14, 2025

❌ 15 Tests Failed:

Tests completed Failed Passed Skipped
23810 15 23795 5850
View the top 3 failed test(s) by shortest run time
tests.tracing.test_misc test_set_meaurement_compared_to_set_data
Stack Traces | 0.071s run time
tests/tracing/test_misc.py:361: in test_set_meaurement_compared_to_set_data
    raise AssertionError("This test is not finished yet.")
E   AssertionError: This test is not finished yet.
tests.tracing.test_misc test_set_meaurement_compared_to_set_data
Stack Traces | 0.073s run time
tests/tracing/test_misc.py:361: in test_set_meaurement_compared_to_set_data
    raise AssertionError("This test is not finished yet.")
E   AssertionError: This test is not finished yet.
tests.tracing.test_misc test_set_meaurement_compared_to_set_data
Stack Traces | 0.075s run time
tests/tracing/test_misc.py:361: in test_set_meaurement_compared_to_set_data
    raise AssertionError("This test is not finished yet.")
E   AssertionError: This test is not finished yet.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker marked this pull request as ready for review January 14, 2025 14:44
@antonpirker
Copy link
Member Author

antonpirker commented Jan 14, 2025

As this is kind of in sleep-mode right now, we keep this PR open but will not merge it right now.

See: https://github.com/getsentry/projects/issues/73

@antonpirker antonpirker removed the request for review from sentrivana January 14, 2025 15:19
@antonpirker antonpirker marked this pull request as draft January 14, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate set_measurement API
1 participant