Fix decoration of cache adapters inheriting parent service #525
+166
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Jun 17, 2021
Jean85
approved these changes
Jun 18, 2021
Jean85
deleted the
fix/cache-tracing-pass-broken-with-service-inheriting-parent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524: when running a compiler pass during the
TYPE_BEFORE_OPTIMIZATIONphase, services inheriting a parent one have not been resolved yet and consequently their class is still set tonull. This was causing the check to decorate the cache adapter according to whether they were implementations of theTagAwareAdapterInterfaceinterface or not to fail, resulting in the decorator to always inherit the baseAdapterInterfaceinterface even when the adaptor should have been an instance ofTagAwareAdapterInterface