Skip to content

Commit 0b5e044

Browse files
ref: remove unreachable code from _handle_numeric_filter (#87359)
callers always check is_numeric_key up front <!-- Describe your PR here. -->
1 parent b0971be commit 0b5e044

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/sentry/api/event_search.py

+5-8
Original file line numberDiff line numberDiff line change
@@ -795,14 +795,11 @@ def _handle_basic_filter(self, search_key, operator, search_value):
795795
def _handle_numeric_filter(self, search_key, operator, search_value):
796796
operator = get_operator_value(operator)
797797

798-
if self.is_numeric_key(search_key.name):
799-
try:
800-
search_value = SearchValue(parse_numeric_value(*search_value))
801-
except InvalidQuery as exc:
802-
raise InvalidSearchQuery(str(exc))
803-
return SearchFilter(search_key, operator, search_value)
804-
805-
return self._handle_text_filter(search_key, operator, SearchValue("".join(search_value)))
798+
try:
799+
search_value = SearchValue(parse_numeric_value(*search_value))
800+
except InvalidQuery as exc:
801+
raise InvalidSearchQuery(str(exc))
802+
return SearchFilter(search_key, operator, search_value)
806803

807804
def visit_date_filter(self, node, children):
808805
(search_key, _, operator, search_value) = children

0 commit comments

Comments
 (0)