Skip to content

Commit 0d45275

Browse files
committed
Fix setup sidebar analytics event
1 parent 2555714 commit 0d45275

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

static/app/components/events/featureFlags/featureFlagInlineCTA.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ export default function FeatureFlagInlineCTA({projectId}: {projectId: string}) {
2020
const {activateSidebar} = useFeatureFlagOnboarding();
2121

2222
function handleSetupButtonClick(e: any) {
23-
trackAnalytics('flags.setup_modal_opened', {organization});
23+
trackAnalytics('flags.setup_sidebar_opened', {
24+
organization,
25+
surface: 'issue_details.flags_section',
26+
});
2427
trackAnalytics('flags.cta_setup_button_clicked', {organization});
2528
activateSidebar(e);
2629
}

static/app/utils/analytics/featureFlagAnalyticsEvents.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ export type FeatureFlagEventParameters = {
1010
direction: 'next' | 'prev';
1111
surface: 'settings';
1212
};
13+
'flags.setup_sidebar_opened': {
14+
surface: 'issue_details.flags_section' | 'issue_details.flags_drawer';
15+
};
1316
'flags.sort_flags': {sortMethod: string};
1417
'flags.table_rendered': {
1518
numFlags: number;
@@ -31,4 +34,5 @@ export const featureFlagEventMap: Record<FeatureFlagEventKey, string | null> = {
3134
'flags.cta_dismissed': 'Flag CTA Dismissed',
3235
'flags.logs-paginated': 'Feature Flag Logs Paginated',
3336
'flags.view-setup-sidebar': 'Viewed Feature Flag Onboarding Sidebar',
37+
'flags.setup_sidebar_opened': 'Feature Flag Setup Sidebar Opened',
3438
};

static/app/views/issueDetails/groupFeatureFlags/flagDrawerCTA.tsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ export default function FlagDrawerCTA() {
1414
const {onClose: closeDrawer} = useDrawerContentContext();
1515

1616
function handleSetupButtonClick(e: any) {
17-
trackAnalytics('flags.setup_modal_opened', {organization});
17+
trackAnalytics('flags.setup_sidebar_opened', {
18+
organization,
19+
surface: 'issue_details.flags_drawer',
20+
});
1821
trackAnalytics('flags.cta_setup_button_clicked', {organization});
1922
closeDrawer?.();
2023
setTimeout(() => {
@@ -55,7 +58,6 @@ const BannerTitle = styled('div')`
5558

5659
const BannerDescription = styled('div')`
5760
margin-bottom: ${space(1.5)};
58-
max-width: 340px;
5961
`;
6062

6163
const ActionButton = styled('div')`
@@ -65,6 +67,7 @@ const ActionButton = styled('div')`
6567

6668
const BannerWrapper = styled('div')`
6769
position: relative;
70+
max-width: 600px;
6871
border: 1px solid ${p => p.theme.border};
6972
border-radius: ${p => p.theme.borderRadius};
7073
padding: ${space(2)};

0 commit comments

Comments
 (0)