Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contexts.app.free_memory is not pretty printed - should be displayed as bytes instead of integer #87238

Closed
ndmanvar opened this issue Mar 17, 2025 · 5 comments · Fixed by #87329
Closed

contexts.app.free_memory is not pretty printed - should be displayed as bytes instead of integer #87238

ndmanvar opened this issue Mar 17, 2025 · 5 comments · Fixed by #87329
Assignees
@leeandher
Labels
Product Area: Issues

Comments

@ndmanvar
Copy link
Contributor

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to an error produced by Sentry's electron SDK
  2. Look at free_memory in contexts.app

Example: https://sentry-sdks.sentry.io/issues/6320479760/|

Image

Expected Result

It should show free_memory in bytes, as it does in contexts.device.app_memory, context.app. app_memory, and context.app.free_memory

Actual Result

Shows free_memory as integer, rather than in bytes
https://sentry-sdks.sentry.io/issues/6320479760/
Image

Product Area

Issues

Link

https://sentry-sdks.sentry.io/issues/6320479760/?project=5650507

DSN

No response

Version

No response
@ndmanvar
Copy link
Contributor Author

Looks like similar behaviour was previously seen (and patched) in #69233

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 17, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Mar 17, 2025

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

@ndmanvar ndmanvar changed the title free_memory is not pretty printed - should be displayed as bytes instead of integer contexts.app.free_memory is not pretty printed - should be displayed as bytes instead of integer Mar 17, 2025
@ndmanvar
Copy link
Contributor Author

customer-case -> https://www.notion.so/sentry/contexts-app-free_memory-is-not-pretty-printed-should-be-displayed-as-bytes-instead-of-integer-1b98b10e4b5d8017b887e5f36eeeb833?pvs=4

@leeandher leeandher self-assigned this Mar 18, 2025
@leeandher
Copy link
Member

I'll fix this up, thanks for reporting!

@leeandher leeandher mentioned this issue Mar 18, 2025
Merged
JoshFerge pushed a commit that referenced this issue Mar 18, 2025
@leeandher
fix(context): Render more known context fields appropriately (#87329)
fd5ca38 
Adds a few context to `app` from
#87238.
While working on it I noticed a few missing from `device` as well, so
updated those.

Resolves #87238

<img width="537" alt="image"
src="https://github.com/user-attachments/assets/c2bc72d4-4505-4cf5-81e5-0be3c74c0178"
/>
<img width="551" alt="image"
src="https://github.com/user-attachments/assets/756e2f86-5429-4ac7-a429-e3940af78d57"
/>
@mrduncan
Copy link
Member

Fixed in #87329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leeandher leeandher

Labels
Product Area: Issues
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(context): Render more known context fields appropriately getsentry/sentry
3 participants
@mrduncan @ndmanvar @leeandher