Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): Render more known context fields appropriately #87329

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

leeandher
Copy link
Member

Adds a few context to app from #87238.
While working on it I noticed a few missing from device as well, so updated those.

Resolves #87238

image image

@leeandher leeandher requested a review from a team as a code owner March 18, 2025 20:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
Copy link
Member

@roggenkemper roggenkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something we can easily add a test for?

@leeandher
Copy link
Member Author

is this something we can easily add a test for?

We don't currently test every field, and for some (like device) there are quite a few so it'd be a bit of a burden the first time and it could fall out of date unless we make the test fail when new keys are added. It's probably worth doing longer term but I don't think for this it's necessary in this PR.

@leeandher leeandher merged commit fd5ca38 into master Mar 18, 2025
41 checks passed
@leeandher leeandher deleted the leander/more-context-fields branch March 18, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contexts.app.free_memory is not pretty printed - should be displayed as bytes instead of integer
2 participants