♻️ ref(metric alerts): refactor slack metric alert logic

[iamrajjoshi]

this pr doesn't do anything new, it decomposes the slack metric alert action handler util so it is ready for me to make the open period refactors

it might be easier to review by cloning locally and taking a look

pr to add open period stuff to follow

[codecov]

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
24419	3	24416	299

View the top 3 failed test(s) by shortest run time

tests.sentry.api.endpoints.test_organization_spans_fields_stats.OrganizationSpansFieldsStatsEndpointTest::test_filter_query

Stack Traces | 3.77s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_spans_fields_stats.py#x1B[0m:157: in test_filter_query
    assert distributions[0]["attributeName"] == "broswer"
#x1B[1m#x1B[31mE   AssertionError: assert 'sentry.transaction' == 'broswer'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     - broswer#x1B[0m
#x1B[1m#x1B[31mE     + sentry.transaction#x1B[0m

tests.sentry.api.endpoints.test_organization_spans_fields_stats.OrganizationSpansFieldsStatsEndpointTest::test_max_buckets

Stack Traces | 4.29s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_spans_fields_stats.py#x1B[0m:117: in test_max_buckets
    assert len(distributions) == max_buckets - 1
#x1B[1m#x1B[31mE   AssertionError: assert 1 == (3 - 1)#x1B[0m
#x1B[1m#x1B[31mE    +  where 1 = len([{'label': 'foo', 'value': 3.0}])#x1B[0m

tests.sentry.api.endpoints.test_organization_spans_fields_stats.OrganizationSpansFieldsStatsEndpointTest::test_distribution_values

Stack Traces | 5.27s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_spans_fields_stats.py#x1B[0m:134: in test_distribution_values
    assert distributions[0]["attributeName"] == "broswer"
#x1B[1m#x1B[31mE   AssertionError: assert 'sentry.transaction' == 'broswer'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     - broswer#x1B[0m
#x1B[1m#x1B[31mE     + sentry.transaction#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[GabeVillalobos]

Ty for the context comments on these! It makes it much easier to review these changes.

[GabeVillalobos]

If possible, could you please break down refactors like these into their own isolated PRs? Having a combination of changes like this makes it harder to review thoroughly when the diffs are bulky.

[Copilot]

Pull Request Overview

This PR refactors the Slack metric alert notification logic by decomposing the incident notification handling into several helper functions and updating the underlying context types.

• Extracts helper functions (_fetch_parent_notification_message_for_incident, _build_notification_payload, _send_notification, _save_notification_message) to better modularize the notification logic.
• Updates the SlackIncidentsMessageBuilder and corresponding tests to use MetricIssueContext instead of separately passing parameters like open_period_identifier, snuba_query, new_status, and metric_value.
• Modifies the typings in metric_detector to include additional fields (e.g., id, subscription) for better traceability.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/sentry/integrations/slack/utils/notifications.py	Refactors notification logic, extracting several helper functions and updating context usage.
tests/sentry/integrations/slack/test_message_builder.py	Adjusts tests to use MetricIssueContext and ensures consistency with the new builder interface.
src/sentry/incidents/typings/metric_detector.py	Updates context classes by adding new fields and modifying factory methods accordingly.
tests/sentry/incidents/action_handlers/test_slack.py	Updates test setup to use MetricIssueContext in place of direct parameters.
src/sentry/integrations/slack/message_builder/incidents.py	Updates builder to accept MetricIssueContext and assigns values accordingly.