Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add tooltip to explain geo selector #77329

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Sep 11, 2024

Work towards #75230

Small tooltip to explain what the subregions are.
image

@DominikB2014 DominikB2014 requested a review from a team as a code owner September 11, 2024 17:51
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 11, 2024
@@ -56,6 +57,8 @@ export default function SubregionSelector({size}: Props) {
return <Fragment />;
}

const tooltip = t('These correspond to the subregions of the UN M49 standard.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there some official page we can link to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking about that too, I'll open up a new PR if I find anything

@DominikB2014 DominikB2014 merged commit 0bc9611 into master Sep 16, 2024
42 of 43 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/add-subregion-tooltip branch September 16, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants