Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releases): Add organization issue-metrics endpoint #86626

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Mar 7, 2025

Implementation of the event-stats endpoint scoped to our use case.

@cmanallen cmanallen requested a review from a team as a code owner March 7, 2025 20:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 7, 2025
@JoshFerge
Copy link
Member

how is this going to be used, is there a spec somewhere?

@cmanallen
Copy link
Member Author

@JoshFerge No spec. This is what I have:

Let me know if you can see those or if you me to write docs for these.

@JoshFerge
Copy link
Member

that makes sense, thanks! and overall what is the product feature this will be used for?

@cmanallen
Copy link
Member Author

@JoshFerge Its part of the releases product. We're adding new charts to the insights page. The idea as I understand it is to show the number of issues created per day, resolved per day, and created for a given release.

@JoshFerge
Copy link
Member

it could be worth attempting to re-use logic from the endpoints used on this page if helpful. i'm also curious if we plan on bringing any of those views into the new page.

https://sentry.sentry.io/settings/stats/issues/

etc.

@cmanallen cmanallen changed the title feat(releases): Add organization issue breakdown endpoint feat(releases): Add organization issue-metrics endpoint Mar 11, 2025
Comment on lines +97 to +98
if len(grouped_series) > 4:
keys = [v[0] for v in nlargest(4, grouped_counter.items(), key=lambda i: i[0])]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smallest series = the least amount of issue counts reported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

"groupBy": ["other"],
"meta": {
"interval": 3600000,
"isOther": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isOther should be true!

Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent with the other charts i think we'd want 5 top releases + everything else is grouped as other - looks like right now it's 4 top releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants