-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(releases): Add organization issue-metrics endpoint #86626
base: master
Are you sure you want to change the base?
Conversation
how is this going to be used, is there a spec somewhere? |
@JoshFerge No spec. This is what I have:
Let me know if you can see those or if you me to write docs for these. |
that makes sense, thanks! and overall what is the product feature this will be used for? |
@JoshFerge Its part of the releases product. We're adding new charts to the insights page. The idea as I understand it is to show the number of issues created per day, resolved per day, and created for a given release. |
it could be worth attempting to re-use logic from the endpoints used on this page if helpful. i'm also curious if we plan on bringing any of those views into the new page. https://sentry.sentry.io/settings/stats/issues/
etc. |
tests/sentry/issues/endpoints/test_organization_issue_metrics.py
Outdated
Show resolved
Hide resolved
if len(grouped_series) > 4: | ||
keys = [v[0] for v in nlargest(4, grouped_counter.items(), key=lambda i: i[0])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smallest series = the least amount of issue counts reported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
"groupBy": ["other"], | ||
"meta": { | ||
"interval": 3600000, | ||
"isOther": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isOther
should be true!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be consistent with the other charts i think we'd want 5 top releases + everything else is grouped as other
- looks like right now it's 4 top releases
Implementation of the event-stats endpoint scoped to our use case.