-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eap-spans): add perf score function #87127
feat(eap-spans): add perf score function #87127
Conversation
…ent-performance_score-function
…ent-performance_score-function
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87127 +/- ##
===========================================
+ Coverage 46.15% 87.76% +41.61%
===========================================
Files 9841 9853 +12
Lines 556950 557727 +777
Branches 21989 21902 -87
===========================================
+ Hits 257042 489490 +232448
+ Misses 299524 67807 -231717
- Partials 384 430 +46 |
…ent-performance_score-function
argument = arguments[index] | ||
if argument_definition.validator is not None: | ||
if not argument_definition.validator(argument): | ||
raise InvalidSearchQuery( | ||
f"{argument} is not a valid argument for {function}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi, I moved the arguments validator under if index < len(arguments)
. Otherwise we could run into index out of range
issues.
i.e we only need to validate arguments, if there's an argument that's being passed in
Closes https://github.com/getsentry/team-visibility/issues/37
performance_score(x)
functionattribute_resolver
toAggregateDefinition
to handle more complicated aggregates where we don't simply aggregate on the parameter.