fix(aci): rename DataConditionHandler type and filter_group #87232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
type
togroup
andfilter_group
tosubgroup
.type
was a bit confusing because it can be confused with the data condition type (ex.age_comparison
orfirst_seen_event
) instead of the handler type (ex.workflow_trigger
oraction_filter
)filter_group
could have implied filtering conditions or data, rather than grouping in the UI. This attribute (now namedsubgroup
) is used to create sub-categories (ex. "filter by frequency")Note that these are just used for the UI so that we can filter/sort the registry.