components: useHoverOverlay should compose props #87246
Open
+73
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Mar 17, 2025
| > | ||
| > | ||
| ) => ({ | ||
| // !!These props are always overriden!! | ||
| 'aria-describedby': describeById, | ||
| ref: setTriggerElement, |
There was a problem hiding this comment.
This is unfortunate, but we need react 19 to be able to fix it. If I attempt to compose the ref it react to error as the ref is a "reserved prop"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip, and anything using useHoverOverlay with skipWrappers is overriding and swallowing handlers.