ref(releases): remove extra filter from environment filter util #87257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
what harm does having the project_ids in the fiter do? it can be a potential security issue if the upstream querys do not filter on project |
wedamija
reviewed
Mar 19, 2025
| @@ -63,7 +63,6 @@ def add_environment_to_queryset(queryset, filter_params): | |||
| if "environment" in filter_params: | |||
| return queryset.filter( | |||
| releaseprojectenvironment__environment__name__in=filter_params["environment"], | |||
| releaseprojectenvironment__project_id__in=filter_params["project_id"], | |||
There was a problem hiding this comment.
This is changing the query you're making. Right now it's filtering on the releaseprojectenvironment__project_id, and you're moving it to releaseproject instead. I don't know if this will break anything, but it seems risky for not much gain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the location below, every callsite for this util is after an explicit project filter. It's only used in this file and
organization_release_details. The naming is confusing so let's remove this filter