fix(symbol sources): Correct schema and validate builtin sources #87267
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt of #86878. Validating the builtin symbol sources against the schema revealed that it was incorrect in several ways (missing file types, filters, `is_public`). I also added the validation of the builtin sources as a test so that in the future a mistake like #86873 fails in CI. Unlike #86878, this temporarily keeps around an incorrect piece of the old schema for backwards compatibility. It will be reomved when the sources using it have been fixed.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87267 +/- ##
========================================
Coverage 87.73% 87.74%
========================================
Files 9865 9862 -3
Lines 558942 558805 -137
Branches 22041 22016 -25
========================================
- Hits 490403 490320 -83
+ Misses 68108 68078 -30
+ Partials 431 407 -24 |
iambriccardo
approved these changes
Mar 19, 2025
| COMMON_SOURCE_PROPERTIES = { | ||
| "id": {"type": "string", "minLength": 1}, | ||
| "name": {"type": "string"}, | ||
| "layout": LAYOUT_SCHEMA, | ||
| "filters": FILTERS_SCHEMA, | ||
| # FIXME: This is temporarily included for backwards compatibility. |
There was a problem hiding this comment.
What happens if we send a payload without filetypes? Will this fail to validate?
My worry is that once we fade out the old field, this code will fail validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt of #86878.
Validating the builtin symbol sources against the schema revealed that it was incorrect in several ways (missing file types, filters,
is_public).I also added the validation of the builtin sources as a test so that in the future a mistake like #86873 fails in CI.
Unlike #86878, this temporarily keeps around an incorrect piece of the old schema for backwards compatibility. It will be removed when the sources using it have been fixed.