Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Spotlight back through devservices #87295

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Mar 18, 2025

Adds and enables Spotlight by default which will now
show up at the bottom right corner with all transactions etc.

This also enables profiling as they would show up in Spotlight.

I'll be following up enabling Spotlight for Snuba to get a more
complete picture after this.

Adds and enables Spotlight by default which will now
show up at the bottom right corner with all transactions etc.

This also enables profiling as they would show up in Spotlight.

I'll be following up enabling Spotlight for Snuba to get a more
complete picture after this.
@BYK BYK requested review from a team as code owners March 18, 2025 17:00
@BYK BYK enabled auto-merge (squash) March 18, 2025 17:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start with a partial rollout to ensure things go smoothly and we don't inadvertently interrupt development?

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/utils/sdk.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #87295   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files        9865     9865           
  Lines      559030   559035    +5     
  Branches    22041    22041           
=======================================
+ Hits       490478   490489   +11     
+ Misses      68121    68115    -6     
  Partials      431      431           

@BYK
Copy link
Member Author

BYK commented Mar 18, 2025

@IanWoodard what's your main concern as this should not have any affect on development and can be turned off by setting SENTRY_SPOTLIGHT=0 env variable (or via local settings overrides) when needed.

@@ -15,6 +15,7 @@ class SdkConfig(TypedDict):
send_default_pii: bool
auto_enabling_integrations: bool
keep_alive: NotRequired[bool]
spotlight: NotRequired[str | bool | None]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can remove None from here now?

Suggested change
spotlight: NotRequired[str | bool | None]
spotlight: NotRequired[str | bool]

@IanWoodard
Copy link
Member

@IanWoodard what's your main concern as this should not have any affect on development and can be turned off by setting SENTRY_SPOTLIGHT=0 env variable (or via local settings overrides) when needed.

It's a new piece of the system that can cause issues for developers if something breaks with spotlight internally. I hear you and am not saying this as a blocker, more so as a suggestion.

@BYK BYK merged commit 7a9bb9d into master Mar 18, 2025
48 checks passed
@BYK BYK deleted the byk/feat/add-spotlight-to-devservices branch March 18, 2025 23:16
@BYK
Copy link
Member Author

BYK commented Mar 19, 2025

Thanks for the review @IanWoodard. Everything around Spotlight is designed with graceful fallbacks and have been tested but I'll both send an announcement and keep an eye for reports.

BYK added a commit to getsentry/snuba that referenced this pull request Mar 19, 2025
This is a follow up to getsentry/sentry#87295. Can be disabled by setting `SENTRY_SPOTLIGHT=0` env variable
BYK added a commit to getsentry/snuba that referenced this pull request Mar 19, 2025
This is a follow up to getsentry/sentry#87295. Can be disabled by
setting `SENTRY_SPOTLIGHT=0` env variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants