Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Adds save query UI to explore #87301

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Mar 18, 2025

Updates the Trace Explorer UI to allow saving/updating queries. New save buttons are added as new options under the Save as... button.

Feature is gated behind the performance-saved-queries flag
image
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@edwardgou-sentry edwardgou-sentry changed the title Adds save query ui to explore feat(explore): Adds save query UI to explore Mar 18, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review March 18, 2025 18:20
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner March 18, 2025 18:20
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, some low priority comments that you can look into. No blockers

@edwardgou-sentry edwardgou-sentry merged commit 508d3c9 into master Mar 19, 2025
41 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/save-explore-query-ui branch March 19, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants