Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ ref(slack): pull thread util methods into a separate class #87302

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

iamrajjoshi
Copy link
Member

i will end up reusing these methods between issue and metric alerts, so pulling it out of the action handler into a generic util class we can reuse.

id imagine we probably delete this after notification platform. didn't make it super generic yet because of the rule of 3.

@iamrajjoshi iamrajjoshi self-assigned this Mar 18, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners March 18, 2025 17:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
Copy link

@eyoandpengu eyoandpengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rule of 3 ? These util methods are only used for slack metric & issue alerts, those are the two strikes (?)

Copy link
Contributor

@Christinarlong Christinarlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved with my test account 💀

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/slack/utils/threads.py 75.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #87302      +/-   ##
==========================================
- Coverage   87.73%   87.73%   -0.01%     
==========================================
  Files        9863     9864       +1     
  Lines      558646   558681      +35     
  Branches    22028    22028              
==========================================
+ Hits       490151   490181      +30     
- Misses      68088    68093       +5     
  Partials      407      407              

@iamrajjoshi iamrajjoshi merged commit 44784f7 into master Mar 18, 2025
48 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/pull-slack-threads-into-class branch March 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants