fix(dashboards): Improve handling for TimeSeries with unknown data types
#87306
+133
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dataType` now always returns something valid, it's never null.
Now that there cannot be an `undefined` or `null` type, don't bother trying to filter those out.
github-actions
bot
added
the
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
nikkikapadia
approved these changes
Mar 19, 2025
static/app/views/dashboards/widgets/timeSeriesWidget/plottables/plottable.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes JAVASCRIPT-2YG7
Closes JAVASCRIPT-2YHG
TimeSeriesWidgetVisualizationis failing on the Queues page if the project doesn't have any specific queue data. If it doesn't, one of the time series come back with anulltype, it has no meta information. In this case, the visualization creates a "duration" axis for the one time series that has data, but doesn't create a fallback axis for the time series with anulltype. This happens because I aggressively filtered outnulltypes, since I didn't realize how often this happens.Rather than patching over that bug, I've added new, more robust types and behaviour.
TimeSeriesis allowed to have anulltype, and the types are now more specifically set in TypeScript. This is just realityPlottableis not allowed to have anulltype. It must provide an actually plottable type! To this end, I added more specific types to explain what is and isn't plottableTimeSeriesWidgetVisualizationonly works on plottables with good types, so the code there doesn't have to change, the error handling has been moved into the plottable implementations and enforced with types