Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): Record the tour exit stage on esc-key press #87307

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

leeandher
Copy link
Member

Improve analytics by recording the dismiss event for escape key press. Also labelling it dismiss, since close implies its recorded on unmount, which is not true.

@leeandher leeandher requested a review from a team March 18, 2025 18:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@leeandher leeandher enabled auto-merge (squash) March 18, 2025 18:51
@leeandher leeandher merged commit 14b387c into master Mar 18, 2025
41 checks passed
@leeandher leeandher deleted the leander/record-stage-tour-exit branch March 18, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants