ref: CommitContextClient methods accept repository instance #87312
+7
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that
repo.name
works well for GitHub (it’s in the formatgetsentry/sentry
, which can be used in the API URL path), whereasrepo.name
in GitLab isname_with_namespace
(formatted asGet Sentry / Sentry
), which is not suitable for use in the URL path.GitLab, in particular, offers an option to use the internal
project_id
in URL paths.https://docs.gitlab.com/api/commits/#list-merge-requests-associated-with-a-commit
I propose a change to make the
get_merge_commit_sha_from_commit
accept a more generic instance ofRepository
, leaving the implementation details to the integration. I've also adjustedCommitContextIntegration.queue_comment_task_if_needed
which uses this method accordingly.