feat(traec): add errors to trace #87314
Merged
+245
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
- This adds a query to the old discover table for errors data for a given trace then zips that back together with spans data that we've gotten from EAP - Longterm errors data will also come from EAP but that's not ready yet
wmak
force-pushed
the
wmak/feat/add-errors-to-trace
branch
from
359e13a to
126075f
Compare
shruthilayaj
approved these changes
Mar 18, 2025
| event_id: str | ||
| parent_span_id: str | None | ||
| event_type: str | ||
| is_transaction: bool |
There was a problem hiding this comment.
nit: move this to SerializedSpan?
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87314 +/- ##
===========================================
+ Coverage 33.19% 87.75% +54.55%
===========================================
Files 8335 9860 +1525
Lines 464115 558839 +94724
Branches 22011 22011
===========================================
+ Hits 154069 490393 +336324
+ Misses 309663 68063 -241600
Partials 383 383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given trace then zips that back together with spans data that we've
gotten from EAP