-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-details): Add universal copy hotkey #87325
Open
jennmueng
wants to merge
5
commits into
master
Choose a base branch
from
jenn/copy-issue-details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,130 @@ | ||
| import {formatRootCauseText} from 'sentry/components/events/autofix/autofixRootCause'; | ||
| import {formatSolutionText} from 'sentry/components/events/autofix/autofixSolution'; | ||
| import { | ||
| type AutofixChangesStep, | ||
| type AutofixCodebaseChange, | ||
| type AutofixData, | ||
| AutofixStatus, | ||
| AutofixStepType, | ||
| } from 'sentry/components/events/autofix/types'; | ||
|
|
||
| export const AUTOFIX_ROOT_CAUSE_STEP_ID = 'root_cause_analysis'; | ||
|
|
||
| export function getRootCauseDescription(autofixData: AutofixData) { | ||
| const rootCause = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.ROOT_CAUSE_ANALYSIS | ||
| ); | ||
| if (!rootCause) { | ||
| return null; | ||
| } | ||
| return rootCause.causes.at(0)?.description ?? null; | ||
| } | ||
|
|
||
| export function getRootCauseCopyText(autofixData: AutofixData) { | ||
| const rootCause = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.ROOT_CAUSE_ANALYSIS | ||
| ); | ||
| if (!rootCause) { | ||
| return null; | ||
| } | ||
|
|
||
| const cause = rootCause.causes.at(0); | ||
|
|
||
| if (!cause) { | ||
| return null; | ||
| } | ||
|
|
||
| return formatRootCauseText(cause); | ||
| } | ||
|
|
||
| export function getSolutionDescription(autofixData: AutofixData) { | ||
| const solution = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.SOLUTION | ||
| ); | ||
| if (!solution) { | ||
| return null; | ||
| } | ||
|
|
||
| return solution.description ?? null; | ||
| } | ||
|
|
||
| export function getSolutionCopyText(autofixData: AutofixData) { | ||
| const solution = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.SOLUTION | ||
| ); | ||
| if (!solution) { | ||
| return null; | ||
| } | ||
|
|
||
| return formatSolutionText(solution.solution, solution.custom_solution); | ||
| } | ||
|
|
||
| export function getSolutionIsLoading(autofixData: AutofixData) { | ||
| const solutionProgressStep = autofixData.steps?.find( | ||
| step => step.key === 'solution_processing' | ||
| ); | ||
| return solutionProgressStep?.status === AutofixStatus.PROCESSING; | ||
| } | ||
|
|
||
| export function getCodeChangesDescription(autofixData: AutofixData) { | ||
| if (!autofixData) { | ||
| return null; | ||
| } | ||
|
|
||
| const changesStep = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.CHANGES | ||
| ) as AutofixChangesStep | undefined; | ||
|
|
||
| if (!changesStep) { | ||
| return null; | ||
| } | ||
|
|
||
| // If there are changes with PRs, show links to them | ||
| const changesWithPRs = changesStep.changes?.filter( | ||
| (change: AutofixCodebaseChange) => change.pull_request | ||
| ); | ||
| if (changesWithPRs?.length) { | ||
| return changesWithPRs | ||
| .map( | ||
| (change: AutofixCodebaseChange) => | ||
| `[View PR in ${change.repo_name}](${change.pull_request?.pr_url})` | ||
| ) | ||
| .join('\n'); | ||
| } | ||
|
|
||
| // If there are code changes but no PRs yet, show a summary | ||
| if (changesStep.changes?.length) { | ||
| // Group changes by repo | ||
| const changesByRepo: Record<string, number> = {}; | ||
| changesStep.changes.forEach((change: AutofixCodebaseChange) => { | ||
| changesByRepo[change.repo_name] = (changesByRepo[change.repo_name] || 0) + 1; | ||
| }); | ||
|
|
||
| const changesSummary = Object.entries(changesByRepo) | ||
| .map(([repo, count]) => `${count} ${count === 1 ? 'change' : 'changes'} in ${repo}`) | ||
| .join(', '); | ||
|
|
||
| return `Proposed ${changesSummary}.`; | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| export const getCodeChangesIsLoading = (autofixData: AutofixData) => { | ||
| if (!autofixData) { | ||
| return false; | ||
| } | ||
|
|
||
| // Check if there's a specific changes processing step, similar to solution_processing | ||
| const changesProgressStep = autofixData.steps?.find(step => step.key === 'plan'); | ||
| if (changesProgressStep?.status === AutofixStatus.PROCESSING) { | ||
| return true; | ||
| } | ||
|
|
||
| // Also check if the changes step itself is in processing state | ||
| const changesStep = autofixData.steps?.find( | ||
| step => step.type === AutofixStepType.CHANGES | ||
| ); | ||
|
|
||
| return changesStep?.status === AutofixStatus.PROCESSING; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should stop it. Query can still run if
refetchis used anywhere, but I think we're good?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally... it doesn't call it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to check my understanding - this is being used to get the group summary if it exists already, but won't create a new summary if one doesn't exist (so we don't need any checks around it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that is the intent and my understanding of how this hook works, other than just not rendering that hook, if we disable it via a check it'll be passing a
falsetoenabledanyways, but this is alwaysfalse