Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aci): debugging logs for workflow engine #87327

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

cathteng
Copy link
Member

Emit logs under a FF to compare when Rules trigger and when Workflows are fired. Log the Workflow id, the corresponding Rule id, and the payload being evaluated.

@cathteng cathteng requested review from a team as code owners March 18, 2025 20:09
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but why does it need a separate flag, couldn't you use the processing flag? like when would you be processing but not logging?

@cathteng
Copy link
Member Author

@ceorourke in case there is something in the future where i've already rolled out to a bunch of orgs via the processing flag but want to investigate logs for a single/few org(s). i probably could have done the same flag 🤷‍♀️

@cathteng cathteng enabled auto-merge (squash) March 18, 2025 20:18
@cathteng cathteng merged commit 9051756 into master Mar 18, 2025
48 checks passed
@cathteng cathteng deleted the cathy/aci/workflow-engine-debug-logs branch March 18, 2025 20:43
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/rules/processing/delayed_processing.py 66.66% 1 Missing ⚠️
src/sentry/rules/processing/processor.py 50.00% 1 Missing ⚠️
...try/workflow_engine/processors/delayed_workflow.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #87327    +/-   ##
========================================
  Coverage   87.73%   87.74%            
========================================
  Files        9863     9864     +1     
  Lines      558345   558900   +555     
  Branches    22030    22030            
========================================
+ Hits       489888   490391   +503     
- Misses      68050    68102    +52     
  Partials      407      407            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants