Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Display labels in cron and uptime create forms #87330

Merged
merged 1 commit into from
Mar 18, 2025
+0 −7
Merged

feat(ui): Display labels in cron and uptime create forms #87330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
name="projectSlug"
label={t('Project')}
placeholder={t('Choose Project')}
hideLabel
projects={projects}
valueIsSlug
inline={false}
Expand All @@ -169,7 +168,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
label={t('Environment')}
placeholder={t('Select an environment')}
noOptionsMessage={() => t('Start typing to create an environment')}
hideLabel
onCreateOption={(env: any) => {
setNewEnvironment(env);
formModel.setValue('environment', env);
Expand Down Expand Up @@ -317,7 +315,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
<TextField
name="name"
label={t('Uptime rule name')}
hideLabel
placeholder={t('Uptime rule name')}
inline={false}
flexibleControlStateSize
Expand All @@ -327,7 +324,6 @@ export function UptimeAlertForm({project, handleDelete, rule}: Props) {
<SentryMemberTeamSelectorField
name="owner"
label={t('Owner')}
hideLabel
menuPlacement="auto"
inline={false}
flexibleControlStateSize
Expand Down
3 changes: 0 additions & 3 deletions static/app/views/monitors/components/monitorForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ function MonitorForm({
<TextField
name="name"
label={t('Name')}
hideLabel
placeholder={t('My Cron Job')}
required
stacked
Expand All @@ -270,7 +269,6 @@ function MonitorForm({
<TextField
name="slug"
label={t('Slug')}
hideLabel
help={tct(
'The [strong:monitor-slug] is used to uniquely identify your monitor within your organization. Changing this slug will require updates to any instrumented check-in calls.',
{strong: <strong />}
Expand All @@ -285,7 +283,6 @@ function MonitorForm({
<SentryProjectSelectorField
name="project"
label={t('Project')}
hideLabel
groupProjects={project =>
platformsWithGuides.includes(project.platform) ? 'suggested' : 'other'
}
Expand Down
Loading