Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(issue-details): Don't default to false for streamlined ui #87337

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Mar 18, 2025

with #87336 will allow us to start opting users into the new experience. Returns None instead of False so that the frontend can determine if we show the new UI or not

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
@roggenkemper roggenkemper marked this pull request as ready for review March 19, 2025 18:14
@roggenkemper roggenkemper requested a review from a team March 19, 2025 18:14
Copy link

codecov bot commented Mar 19, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
24451 1 24450 299
View the top 1 failed test(s) by shortest run time
tests.sentry.workflow_engine.migration_helpers.test_migrate_alert_rule.SinglePointOfEntryTest::test_spe_create
Stack Traces | 3.14s run time
#x1B[1m#x1B[.../workflow_engine/migration_helpers/test_migrate_alert_rule.py#x1B[0m:1330: in test_spe_create
    dual_write_alert_rule(self.metric_alert)
#x1B[1m#x1B[.../workflow_engine/migration_helpers/alert_rule.py#x1B[0m:593: in dual_write_alert_rule
    migrate_alert_rule(alert_rule)
#x1B[1m#x1B[.../workflow_engine/migration_helpers/alert_rule.py#x1B[0m:552: in migrate_alert_rule
    workflow_name = get_workflow_name(alert_rule)
#x1B[1m#x1B[.../workflow_engine/migration_helpers/utils.py#x1B[0m:53: in get_workflow_name
    description = get_action_description(action) + ", "
#x1B[1m#x1B[.../workflow_engine/migration_helpers/utils.py#x1B[0m:23: in get_action_description
    if action.target:
#x1B[1m#x1B[.../incidents/models/alert_rule.py#x1B[0m:476: in target
    return user_service.get_user(user_id=int(self.target_identifier))
#x1B[1m#x1B[.../services/user/service.py#x1B[0m:201: in get_user
    return get_user(user_id)
#x1B[1m#x1B[.../rpc/caching/service.py#x1B[0m:76: in __call__
    return self.get_one(object_id)
#x1B[1m#x1B[.../rpc/caching/service.py#x1B[0m:109: in get_one
    return _consume_generator(self.resolve_from(object_id, values))
#x1B[1m#x1B[.../rpc/caching/impl.py#x1B[0m:24: in _consume_generator
    g.send(None)
#x1B[1m#x1B[.../rpc/caching/service.py#x1B[0m:99: in resolve_from
    r = self.cb(i)
#x1B[1m#x1B[.../services/user/service.py#x1B[0m:320: in get_user
    users = user_service.get_many(filter={"user_ids": [user_id]})
#x1B[1m#x1B[.../hybridcloud/rpc/service.py#x1B[0m:354: in remote_method
    return dispatch_remote_call(
#x1B[1m#x1B[.../hybridcloud/rpc/service.py#x1B[0m:476: in dispatch_remote_call
    return remote_silo_call.dispatch(use_test_client)
#x1B[1m#x1B[.../hybridcloud/rpc/service.py#x1B[0m:511: in dispatch
    serial_response = self._send_to_remote_silo(use_test_client)
#x1B[1m#x1B[.../hybridcloud/rpc/service.py#x1B[0m:572: in _send_to_remote_silo
    response = self._fire_test_request(headers, data)
#x1B[1m#x1B[.../hybridcloud/rpc/service.py#x1B[0m:631: in _fire_test_request
    in_test_assert_no_transaction(
#x1B[1m#x1B[.../db/postgres/transactions.py#x1B[0m:101: in in_test_assert_no_transaction
    assert not hybrid_cloud.simulated_transaction_watermarks.connection_transaction_depth_above_watermark(
#x1B[1m#x1B[31mE   AssertionError: remote service method to .../rpc/user/get_many/ called inside transaction!  Move service calls to outside of transactions.#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@roggenkemper roggenkemper merged commit 825502d into master Mar 19, 2025
47 of 48 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/updateuserendpoint branch March 19, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants