Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): Update the Session Health layout for Mobile & Web #87344

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Mar 18, 2025

New layouts are:
SCR-20250318-mmjo
SCR-20250318-mmki

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@ryan953 ryan953 marked this pull request as ready for review March 18, 2025 21:16
@ryan953 ryan953 requested a review from a team as a code owner March 18, 2025 21:16
@ryan953 ryan953 requested a review from a team March 18, 2025 21:39
setFilters: (filter: string[]) => void;
view: DomainView | '';
}) {
switch (view) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a longer function to have this switch inside of it.. but i hope that it's worth the tradeoff of being easier to read.

@ryan953 ryan953 enabled auto-merge (squash) March 18, 2025 22:02
@ryan953 ryan953 merged commit 59acf97 into master Mar 18, 2025
41 checks passed
@ryan953 ryan953 deleted the ryan953/insights-session-health-layout-ref branch March 18, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants