Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): Add profile hours UI to user spend notifications page #87350

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

dashed
Copy link
Member

@dashed dashed commented Mar 18, 2025

Closes https://github.com/getsentry/getsentry/issues/16818

This adds continuous profiling to the spend notifications page on the user's personal notifications preferences.

This also adds the organizations:continuous-profiling-billing feature so that we can feature flag billing-related features until launch. The newly added feature is a follow up to #80787.

This is intentionally separate from organizations:continuous-profiling feature flag.

@dashed dashed requested a review from a team March 18, 2025 22:01
@dashed dashed self-assigned this Mar 18, 2025
@dashed dashed requested a review from a team as a code owner March 18, 2025 22:01
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 18, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #87350       +/-   ##
===========================================
+ Coverage   54.59%   87.75%   +33.16%     
===========================================
  Files        9873     9879        +6     
  Lines      559958   560220      +262     
  Branches    22075    22072        -3     
===========================================
+ Hits       305683   491598   +185915     
+ Misses     253273    68218   -185055     
+ Partials     1002      404      -598     

@dashed dashed force-pushed the profile-hours/user-notification-setting-frontend branch from de8e7e3 to c78204a Compare March 19, 2025 20:45
@dashed dashed merged commit fa6e6a6 into master Mar 20, 2025
51 checks passed
@dashed dashed deleted the profile-hours/user-notification-setting-frontend branch March 20, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants