-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): add CTA to flag drawer #87354
base: master
Are you sure you want to change the base?
Conversation
…sentry into aliu/ff-dist-cta
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
static/app/views/issueDetails/groupFeatureFlags/flagDrawerCTA.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDrawerCTA.tsx
Outdated
Show resolved
Hide resolved
@@ -61,6 +65,18 @@ export default function GroupFeatureFlagsDrawerContent({ | |||
return searchedTags; | |||
}, [data, search, tagValues]); | |||
|
|||
const organization = useOrganization(); | |||
const project = useProjectFromSlug({organization, projectSlug: group.project?.slug}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does simply group.project
not work for project
?
const project = useProjectFromSlug({organization, projectSlug: group.project?.slug}); | |
const project = group.project; |
@@ -0,0 +1,107 @@ | |||
import styled from '@emotion/styled'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can any of this file & featureFlagInlineCTA.tsx
be refactored into a reusable component?
Closes #87149, branched from #87251

Slack screen recording of behavior
Also updates style for inline CTA (issue details "flags" section):

Adds a missing analytics definition, for an event we were emitting from inline CTA
'flags.setup_sidebar_opened'