feat(issue-views): Change add view button to just + icon near starred views header' #87360
+95
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
Mar 18, 2025
Comment on lines
+95
to
+96
| height: 14px !important; | ||
| margin: 0 !important; |
There was a problem hiding this comment.
Idk why but there are top level sentry.css styles that are forcing margin and height properties on the loadingindicator.mini class.
MichaelSun48
commented
Mar 18, 2025
| @@ -149,12 +151,13 @@ export function IssueViewNavItemContent({ | |||
| dragListener={false} | |||
| dragControls={controls} | |||
| style={{ | |||
| ...(isDragging | |||
| ...(isDragging || scrollPosition === 0 | |||
There was a problem hiding this comment.
This kinda fixes that really annoying issue where views wouldn't animate in and out as a result of the originY styles. We only need to apply those styles if the user has scrolled down on the page, since that's what triggers the framer motion bug.
MichaelSun48
commented
Mar 18, 2025
| position: relative; | ||
| background-color: ${p => p.theme.translucentSurface200}; | ||
| background-color: ${p => (p.grabbing ? p.theme.translucentSurface200 : 'transparent')}; |
There was a problem hiding this comment.
Views had a slightly different background in their resting state. This applies the translucent border only when dragging.
MichaelSun48
commented
Mar 18, 2025
Comment on lines
+262
to
269
| <SecondaryNav.Section | ||
| title={ | ||
| <TitleWrapper> | ||
| {t('Starred Views')} | ||
| <IssueViewAddViewButton baseUrl={baseUrl} /> | ||
| </TitleWrapper> | ||
| } | ||
| > |
There was a problem hiding this comment.
This is moved in from the navigation.tsx file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Add View Button from below the views to the right of the "Starred Views" header. Adds a tooltip that says "Add View"
Before:
After:
Includes a couple of annotated drive by changes that aren't super related