Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-trace): Hiding issue details trace contexts and explore navigations based on the performance-view flag #87362

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

Abdkhan14
Copy link
Contributor

No description provided.

…gations based on the performance-view flag
@Abdkhan14 Abdkhan14 requested review from a team as code owners March 18, 2025 23:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
Copy link

codecov bot commented Mar 19, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9969 2 9967 5
View the top 2 failed test(s) by shortest run time
TraceContext returns values and according to the parameters
Stack Traces | 0.025s run time
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 5
+ Received  + 1

@@ -1,12 +1,8 @@
  Array [
    Object {
-     "action": Object {
-       "link": ObjectContaining {
-         "pathname": ".../org-slug/discover/results/",
-       },
-     },
+     "action": undefined,
      "key": "trace_id",
      "subject": "Trace ID",
      "value": "61d2d7c5acf448ffa8e2f8f973e2cd36",
    },
    Object {
    at Object.<anonymous> (.../contexts/knownContext/trace.spec.tsx:54:9)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
TraceContext renders with meta annotations correctly
Stack Traces | 0.123s run time
TestingLibraryElementError: Unable to find an accessible element with the role "link" and name "61d2d7c5acf448ffa8e2f8f973e2cd36"

Here are the accessible roles:

  button:

  Name "Expand":
  ...

  Name "1 item":
  ...

  Name "Expand":
  ...

  Name "3 items":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../contexts/knownContext/trace.spec.tsx:145:40)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Abdkhan14 Abdkhan14 merged commit 32f101e into master Mar 20, 2025
40 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/traces-performance-view-flag branch March 20, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants