Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Tweak enhancement naming and documentation #87363

Merged
merged 27 commits into from
Mar 19, 2025

Conversation

lobsterkatie
Copy link
Member

This is a bunch of renaming and comment-adding that I've done as part of my travels through the enhancements code, both recently and last fall. No behavior changes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/grouping/enhancer/rules.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #87363       +/-   ##
===========================================
+ Coverage   33.18%   87.73%   +54.55%     
===========================================
  Files        8341     9864     +1523     
  Lines      464858   559027    +94169     
  Branches    22043    22043               
===========================================
+ Hits       154256   490457   +336201     
+ Misses     310171    68139   -242032     
  Partials      431      431               

@lobsterkatie lobsterkatie marked this pull request as ready for review March 19, 2025 17:28
@lobsterkatie lobsterkatie requested a review from a team as a code owner March 19, 2025 17:28
@lobsterkatie lobsterkatie merged commit 87ac5cd into master Mar 19, 2025
49 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-various-enhancement-clarifications branch March 19, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants