feat(shared-views): Remove position usage in groupsearchview serializer #87367
+77
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSun48
commented
Mar 18, 2025
| user_id=request.user.id, | ||
| group_search_view_id__in=[view.id for view in new_view_state], | ||
| ) | ||
| last_visited_map = {lv.group_search_view_id: lv.last_visited for lv in last_visited_views} |
There was a problem hiding this comment.
This line was the issue: I was sending over an entire GroupSearchViewLastVisited entry rather than just the last_visited timestamp, which was causing the serializability error.
MichaelSun48
commented
Mar 18, 2025
Comment on lines
+288
to
+303
| @with_feature({"organizations:issue-stream-custom-views": True}) | ||
| @with_feature({"organizations:global-views": True}) | ||
| @freeze_time("2025-03-07T00:00:00Z") | ||
| def test_response_with_last_visited(self) -> None: | ||
| GroupSearchViewLastVisited.objects.create( | ||
| user_id=self.user.id, | ||
| organization=self.organization, | ||
| group_search_view=self.base_data["user_one_views"][0], | ||
| last_visited=timezone.now(), | ||
| ) | ||
|
|
||
| views = self.client.get(self.url).data | ||
| response = self.get_success_response(self.organization.slug, views=views) | ||
|
|
||
| assert response.data[0]["lastVisited"] == timezone.now() | ||
| assert response.data[1]["lastVisited"] is None |
There was a problem hiding this comment.
This test correctly reproduced the error and now passes with the fix.
github-actions
bot
added
the
Scope: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-3QBN
Clone of #87297, but includes a fix in ed8c6fc that was causing some json serialization issues shown in the Sentry error above.