Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Backfill value type for message latency chart #87454

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

gggritso
Copy link
Member

See code comment for details.

Before:
Screenshot 2025-03-19 at 5 43 50 PM

Gross! We can't figure out the value type for one of the series, so we create an extra axis for it. That data actually is always "duration", so it should use the existing "duration" axis.

After:
Screenshot 2025-03-19 at 5 44 11 PM

Much better.

@gggritso gggritso requested a review from a team as a code owner March 19, 2025 21:45
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 19, 2025
Use `cloneDeep` instead, which leaves the data alone.
@gggritso gggritso merged commit 5ca18b3 into master Mar 20, 2025
40 checks passed
@gggritso gggritso deleted the fix/insights/backfill-missing-series-data-type branch March 20, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants