ref: completely type sentry.api.event_search

[asottile-sentry]

No description provided.

[asottile-sentry]

I know this looks like a lot -- but this is entirely just:

• variable renames so they aren't clobbered
• annotations for parameter names

hopefully the prior changes can put in context how careful I've been trying to be for this:

• ref: remove some dead code from _handle_text_filter #87434
• ref: remove try around parse_numeric_value #87432
• ref: remove try: around parse_percentage #87368
• ref: remove try around parse_size #87364
• ref: add tests for invalid durations #87361
• ref: remove unreachable code from _handle_numeric_filter #87359
• ref: add tests for invalid datetime range #87358
• ref: add types to the "easy" functions in event_search #87355
• ref: make flatten(...) only operate on recursive lists #87351
• ref: SearchBoolean is never constructed: remove base class #87346
• ref: fix some of the types once api.event_search is typed #87303
• ref: make SearchConfig generic on its allow_boolean setting #87291
• ref: SearchVisitor always takes SearchConfig #87225
• ref: implement missing to_query_string for AggregateFilter #87091
• ref: require query: str for parse_search_query #87080
• ref: remove config_overrides= argument to parse_search_query #87022
• ref: combine remove_empty and remove_optional #86993
• ref: fix parsing of "empty" parenthesized search query #86845
• ref: remove builder= as an argument to parse_search_query #86829
• ref: fix and type implementation of flatten #86798
• ref: improve test coverage of sentry.api.event_search #86731

[codecov]

Codecov Report

Attention: Patch coverage is 97.98658% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/monkey/__init__.py	75.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #87461   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files        9889     9889           
  Lines      560874   560878    +4     
  Branches    22104    22104           
=======================================
+ Hits       492128   492143   +15     
+ Misses      68342    68331   -11     
  Partials      404      404           

[JoshFerge]

amazing work!

[joshuarli]

sick