-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkout): Reserved step for modern plans #87465
Open
isabellaenriquez
wants to merge
6
commits into
master
Choose a base branch
from
isabella/checkout-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
vbro
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of milestone 1
Figma: https://www.figma.com/design/o5VEiQ84cLCZEDUcP1lIHV/Checkout-Prototype?node-id=653-8250&t=sjKItWmz1zAoRWTC-0
This PR does the following:
AddDataVolume
to a function componentAddDataVolume
component so it can be reused for modern plansnew flow to be released later
reserved.step.mov
For legacy plans, this step should look largely the same as before; the only difference is that crons and uptime are no longer listed in this step:
legacy pre-performance plans
legacy performance plans
When this deploys, checkout for modern plans should still look the same as before as this PR does not add the new step to the checkout flow for modern plans; this will be covered in a followup PR.
modern plans