Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-trace): Disabling collapse state persistence for trace drawer sections #87471

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

Abdkhan14
Copy link
Contributor

We want the trace drawer sections to be initially expanded and don't want collapsed state to persist.

Screenshot 2025-03-19 at 9 51 51 PM

Added a disableCollapsePersistence prop to the FoldSection component and used it in the trace drawer.

Added section to component stories.

@Abdkhan14 Abdkhan14 requested review from a team as code owners March 20, 2025 01:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 20, 2025
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. There's a lot of prop drilling though. Not sure if it would make sense to start using a context here.

@Abdkhan14 Abdkhan14 merged commit c0f4685 into master Mar 20, 2025
41 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-drawer-sections-persistence branch March 20, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants