Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(spans): Reorganize the segment consumer code #87481

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

jan-auer
Copy link
Member

Moves enrichment into a dedicated module and improves typing of Spans passed
around in the factory. This should make it more clear, at which stage the spans
have been enriched.

@jan-auer jan-auer requested a review from a team as a code owner March 20, 2025 10:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/spans/consumers/process_segments/enrichment.py 85.93% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #87481   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files        9891     9895    +4     
  Lines      560996   561057   +61     
  Branches    22136    22136           
=======================================
+ Hits       492198   492259   +61     
  Misses      68394    68394           
  Partials      404      404           

@jan-auer jan-auer enabled auto-merge (squash) March 20, 2025 12:49
@jan-auer jan-auer merged commit c1165d6 into master Mar 20, 2025
48 checks passed
@jan-auer jan-auer deleted the ref/segment-reorganize branch March 20, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants