ci: provide arm64 image build #6825
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,15 +4,21 @@ on: | ||
| branches: [master] | ||
| jobs: | ||
| build: | ||
| strategy: | ||
| matrix: | ||
| arch: [amd64, arm64] | ||
| runs-on: |- | ||
| ${{fromJson('{ | ||
| "amd64": "ubuntu-22.04", | ||
| "arm64": "ubuntu-22.04-arm" | ||
| }')[matrix.arch] }} | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - run: docker login --username '${{ github.actor }}' --password '${{ github.token }}' ghcr.io | ||
|
|
||
| - run: docker buildx create --driver docker-container --use | ||
|
|
||
| @@ -24,9 +30,7 @@ jobs: | ||
|
|
||
| if [ ${{ github.event_name }} = 'push' ]; then | ||
| args+=( | ||
| --cache-to type=registry,ref=ghcr.io/getsentry/snuba:${{ matrix.arch }}-buildcache,mode=max | ||
| --push | ||
| ) | ||
| fi | ||
| @@ -41,27 +45,44 @@ jobs: | ||
|
|
||
| docker buildx build \ | ||
| --pull \ | ||
| --platform linux/${{ matrix.arch }} \ | ||
| --cache-from type=registry,ref=ghcr.io/getsentry/snuba:${{ matrix.arch }}-buildcache \ | ||
| --tag ghcr.io/getsentry/snuba:${{ matrix.arch }}-${{ github.sha }} \ | ||
| --target application \ | ||
| "${args[@]}" \ | ||
| . | ||
|
|
||
| assemble: | ||
| needs: build | ||
| if: github.event_name != 'pull_request' | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Docker Login | ||
| run: docker login --username '${{ github.actor }}' --password '${{ github.token }}' ghcr.io | ||
|
|
||
| - name: Assemble Sha Image | ||
| run: | | ||
| docker buildx imagetools create -t "ghcr.io/getsentry/snuba:${{ github.sha }}" \ | ||
| "ghcr.io/getsentry/snuba:arm64-${{ github.sha }}" \ | ||
| "ghcr.io/getsentry/snuba:amd64-${{ github.sha }}" | ||
|
|
||
| - name: Assemble Latest Image | ||
| if: github.ref_name == 'master' && github.event_name != 'pull_request' | ||
| run: | | ||
| docker buildx imagetools create -t "ghcr.io/getsentry/snuba:latest" \ | ||
|
There was a problem hiding this comment. are you 100% sure that There was a problem hiding this comment. Yes it does, this is taken from Symbolicator and that's how it pushes its images. |
||
| "ghcr.io/getsentry/snuba:arm64-${{ github.sha }}" \ | ||
| "ghcr.io/getsentry/snuba:amd64-${{ github.sha }}" | ||
|
|
||
| publish-to-dockerhub: | ||
| needs: [build, assemble] | ||
| name: Publish Snuba to DockerHub | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 # v3.1.0 | ||
| - name: Pull the test image | ||
| id: image_pull | ||
| env: | ||
| IMAGE_URL: ghcr.io/getsentry/snuba:${{ github.sha }} | ||
| shell: bash | ||
| run: | | ||
| docker pull "$IMAGE_URL" | ||
| @@ -77,7 +98,7 @@ jobs: | ||
| echo "sha=$SHORT_SHA" >> $GITHUB_OUTPUT | ||
| fi | ||
| - name: Push built docker image | ||
| if: github.ref_name == 'master' && github.event_name != 'pull_request' | ||
| shell: bash | ||
| env: | ||
| SHORT_SHA: ${{ steps.short_sha.outputs.sha }} | ||
| @@ -97,7 +118,7 @@ jobs: | ||
| docker push getsentry/snuba:nightly | ||
|
|
||
| self-hosted-end-to-end: | ||
| needs: [build, assemble] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
|
|
||
| @@ -106,5 +127,5 @@ jobs: | ||
| uses: getsentry/self-hosted@master | ||
| with: | ||
| project_name: snuba | ||
| image_url: ghcr.io/getsentry/snuba:${{ github.sha }} | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to see some real crazy usage of fromJson, check out what cargo-dist does. it seems that one can generate matrices programmatically, put them into job output and then reference them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, the credits goes to @Dav1dde lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@untitaker Relay does that 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note, this is absolutely not necessary here, I did it this way to not have the runner show up in the generated job name in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, it's useful. We need to use the correct GHA runner with the corresponding arch name (amd64/arm64)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, you can just put it in the matrix. The purpose of this is simply to not have the runner name in the job name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it makes sense lol.