feat(autocomplete): Implement key autocomplete for eap items #6978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_autocomplete_impl
…/snuba into volo/eap/key_autocomplete_impl
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
onkar
reviewed
Mar 20, 2025
Comment on lines
82
to
85
| map_elems = [] | ||
| for key, val in ATTRIBUTE_MAPPINGS.items(): | ||
| map_elems.append(key) | ||
| map_elems.append(val) |
There was a problem hiding this comment.
Are these map_elems intended to be used anywhere?
| @@ -300,7 +338,18 @@ def t(row: Row) -> TraceItemAttributeNamesResponse.Attribute: | |||
| name=attr_name, type=getattr(AttributeKey.Type, attr_type) | |||
| ) | |||
|
|
|||
| return list(map(t, query_res.result.get("data", []))) | |||
| data = query_res.result.get("data", []) | |||
There was a problem hiding this comment.
nit: If "data" is not present in query_res.result, then we get an empty list, which is further extended but not persisted back to the result. Should it be persisted?
There was a problem hiding this comment.
no, the query_res variable is not used for anything after this function. Also, the data key in practice is always present
onkar
approved these changes
Mar 20, 2025
| @@ -166,6 +166,12 @@ def _execute( | |||
| self, in_msg: TraceItemAttributeValuesRequest | |||
| ) -> TraceItemAttributeValuesResponse: | |||
| in_msg.limit = in_msg.limit or 1000 | |||
| # HACK (Volo): for backwards compatibility. eap_spans used to store this value, | |||
| # eap_items does not | |||
| if in_msg.key == "sentry.service": | |||
There was a problem hiding this comment.
I don't think sentry.service is used anywhere on the sentry side, probably safe to remove
There was a problem hiding this comment.
it is, I checked with folks this morning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6970 to be merged
Requires getsentry/sentry#87511 to be merged
Resolves https://github.com/getsentry/eap-planning/issues/204
Implements the key autocomplete without the intersecting attributes filter, no longer supports attribute pagination:
See summarized decision here:
https://www.notion.so/sentry/Deprecating-pagination-in-autocomplete-APIs-1b98b10e4b5d80ab832ff700d49f15c3