Fix errors with validation templates when no approver set #19194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
changed the title
cconard96
force-pushed
the
fix/validation_template_noapprover
branch
from
d03d101 to
088290a
Compare
cedric-anne
approved these changes
Mar 19, 2025
AdrienClairembault
requested changes
Mar 19, 2025
Comment on lines
+136
to
+153
| cy.get('.timeline-buttons .main-actions button.dropdown-toggle-split').click(); | ||
| cy.findByText('Ask for validation').click(); | ||
| cy.get('.itilvalidation').within(() => { | ||
| cy.getDropdownByLabelText('Template').selectDropdownValue(`test ${rand}`); | ||
| cy.get('select[name="[validatortype]"]').should('have.value', 'User'); | ||
| cy.get('select[name="items_id_target"]').should('have.value', '2'); | ||
| cy.get('textarea[name="comment_submission"]').awaitTinyMCE().should('contain.text', 'test content'); | ||
| }); | ||
| cy.visit(`/front/ticket.form.php?id=${ticket_id}`); | ||
| cy.get('.timeline-buttons .main-actions button.dropdown-toggle-split').click(); | ||
| cy.findByText('Ask for validation').click(); | ||
| cy.get('.itilvalidation').within(() => { | ||
| cy.getDropdownByLabelText('Template').selectDropdownValue(`test no approver ${rand}`); | ||
| cy.get('select[name="[validatortype]"]').should('have.value', '0'); | ||
| cy.get('select[name="items_id_target"]').should('not.exist'); | ||
| cy.get('textarea[name="comment_submission"]').awaitTinyMCE().should('contain.text', 'no approver test content'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Please use stronger selectors (accessibility based or with tests ids).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Fixes #19170