[extractor/golang] Generate valid golang purls #501
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the purl spec, the golang type is using both name and namespace. Scalibr is only populating the name, resulting in a single percent-encoded string instead of a namespace with multiple segments and a name: Example: - Purl-spec: pkg:golang/github.com/google/osv-scalibr - Scalibr: pkg:golang/github.com%2Fgoogle%2Fosv-scalibr See: https://github.com/package-url/purl-spec/blob/main/PURL-TYPES.rst#golang
|
Thanks for catching this! |
erikvarga
reviewed
Mar 10, 2025
| @@ -140,10 +140,12 @@ func (e Extractor) Extract(ctx context.Context, input *filesystem.ScanInput) ([] | |||
|
|
|||
| // ToPURL converts an inventory created by this extractor into a PURL. | |||
| func (e Extractor) ToPURL(i *extractor.Inventory) *purl.PackageURL { | |||
| nameParts := strings.Split(i.Name, "/") | |||
There was a problem hiding this comment.
Since we're doing this in two places can you move the ToPURL logic into a separate library inside language/golang, similar to https://github.com/google/osv-scalibr/blob/main/extractor/filesystem/language/python/internal/pypipurl/pythonpurl.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the purl spec, the golang type is using both name and namespace.
Scalibr is only populating the name, resulting in a single percent-encoded string instead of a namespace with multiple segments and a name: Example:
See: https://github.com/package-url/purl-spec/blob/main/PURL-TYPES.rst#golang