-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotnet pe support #505
base: main
Are you sure you want to change the base?
Dotnet pe support #505
Conversation
fix: pe parsing
fix: return nil when return error (ivs are be empty anyway)
Looks like there are some merge conflicts - can you do a sync? I think it's also possible to give reviewers push permisisons after which they can resolve the merge conflicts too (like I did here). |
The branch should be synched now. I don't know if I'm able to grant you push permission to the PRs. I'll look into it and get back to you once I have more information. |
PiperOrigin-RevId: 736742277
This pull request adds the implementation of the
dotnet/pe
extractor.Implementation
The plugin uses https://github.com/saferwall/pe to extract .NET PE file data.
It’s possible to implement this without dependencies using the https://pkg.go.dev/debug/pe package, but it would require around 2000 lines of code to manually parse the .NET-specific CLR header, which contains .DLL information.
For reference, check the following parts of the saferwall/pe code:
Test set
The test was created by writing a simple "HelloWorld" app in .NET with mock dependencies. The expected dependencies were verified using https://github.com/dnSpyEx/dnSpy.
Adding a few more test cases would certainly be beneficial. Do you have any ideas or constraints on which PE files I could include in the test set?