Move inventories + findings under a top-level struct inside ScanResults. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_733262169
branch
from
244c9db to
3989904
Compare
copybara-service
bot
force-pushed
the
test_733262169
branch
from
3989904 to
9e10de5
Compare
This allows us to add new result types for things that are not software packages or security findings (e.g. running processes, open ports). Instead of returning just packages, extractor plugins now return the generic inventory type which allows them to extract more inventory types such as secrets in the future. Note that we still use the software package struct to store non-software inventory such as containerd runtimes. Moving that to a separate type will be done in a follow-up change. PiperOrigin-RevId: 733262169
copybara-service
bot
force-pushed
the
test_733262169
branch
from
9e10de5 to
2586628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move inventories + findings under a top-level struct inside ScanResults.
This allows us to add new result types for things that are not software packages or security findings (e.g. running processes, open ports).
Instead of returning just packages, extractor plugins now return the generic inventory type which allows them to extract more inventory types such as secrets in the future.
Note that we still use the software package struct to store non-software inventory such as containerd runtimes. Moving that to a separate type will be done in a follow-up change.