ci: run linter on all OSs #548
Draft
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
linting/run-on-os
branch
from
93bc91f to
d139671
Compare
G-Rath
force-pushed
the
linting/run-on-os
branch
from
edc3dde to
798caa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that
go:builddirectives are relevant to linting, which makes sense in hindsight as the linter works by compiling the actual code for some lints - this means that in order to lint OS specific files, we need to run the linter on that particular OS.That's not the end of the world, but I do wish I could come up with a cunning way of somehow reducing the double-up linting violations, but I don't think there's a way to reliably do that without risking missing some files (in theory we could do it with some kind of report merging, but that's not supported by the linter)