ci: run linter on macos-latest
#560
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fwiw @another-rex currently I'm not planning on doing this in osv-scanner because we've only got a single OS-based file, and I don't imagine we'll introduce any in the near future, so I don't think it's worth running the linter three times for every change over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the linter involves compiling files, it won't lint files that are excluded due to
go:builddirectives, so we really should be running the linter across all three OSs - currently running on Windows works but has a number of errors mostly around imports that I suspect are due to file path and line ending differences, but macOS works fine so we might as well start running on that