-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NPE in parsing error status during HttpJson server streaming #3640
base: main
Are you sure you want to change the base?
Conversation
67662df
to
30933ae
Compare
@blakeli0, could you please review this? Thanks. |
@baeminbo Thanks for reporting this issue and creating this PR! However, I would like to discuss the priority of this issue before we jumping to the solution. Please see my latest comment googleapis/java-spanner#3640 (comment). |
Unary calls do not throw the NullPointerException because a similar fix to this PR has already been applied. HttpJsonDirectCallable sets It appears that httpjson doesn't support client-streaming and bidi-streaming.
|
Yes, you are right that unary callables already applied a similar fix, client streaming and bidi streaming are not supported in httpjson, they were poor examples. As I mentioned in googleapis/java-spanner#3640 (comment), I think the best way to move forward is to create a dedicated issue for it, we can discuss potential solutions and priority there. |
Fix NPE in googleapis/java-spanner#3640.
However, a separate type resolution error will still prevent successful error status parsing. This requires a more substantial change, as discussed in #2237 (comment)..
Thank you for opening a Pull Request! Before submitting your PR, please read our contributing guidelines.
There are a few things you can do to make sure it goes smoothly: