feat: add customer logging provider to support structured logging for SLF4J 1.x + Logback 1.2.x #3693
Conversation
product-auto-label
bot
added
size: l
JoeWang1127
changed the title
...ogging/logback-extension/src/main/java/com/google/api/logging/SDKLoggingMdcJsonProvider.java
Outdated
Show resolved
Hide resolved
| for (Map.Entry<String, String> entry : mdcProperties.entrySet()) { | ||
| String fieldName = entry.getKey(); | ||
| String entryValueString = entry.getValue(); | ||
| if (fieldName == null || entryValueString == null) { |
There was a problem hiding this comment.
logstash-logback has some customization capabilities that I suspect are fairly easy to restore here, like configure specific entries in the MDC to be included or excluded and renaming keys, ref: readme:mdc-fields. It might be as easy as adding these conditions here, or a bit more involved. Can you take a look? I think it nice to have it preserved.
https://github.com/logfellow/logstash-logback-encoder/blob/76f5295f35bc44518af91bfccb07a8ecb142229c/src/main/java/net/logstash/logback/composite/loggingevent/MdcJsonProvider.java#L102-L103
There was a problem hiding this comment.
Added these features.
|
|
In this PR:
b/394880750