chore: create logging module structure #3706
Conversation
pom.xml
Outdated
| @@ -24,6 +24,7 @@ | |||
| <module>gapic-generator-java-bom</module> | |||
| <module>java-shared-dependencies</module> | |||
| <module>sdk-platform-java-config</module> | |||
| <module>java-sdk-logging</module> | |||
There was a problem hiding this comment.
Is this included in releases?
There was a problem hiding this comment.
No, the module is skipped during normal release.
There was a problem hiding this comment.
Great. Do you mind point me to where the normal release is setup?
There was a problem hiding this comment.
maven-deploy-plugin in these pom.xmls are skipped.
This is the same setup in the root pom.xml.
There was a problem hiding this comment.
Does it have to be added to the root pom?
There was a problem hiding this comment.
No, it doesn't need to add to root pom.
Without this line, we need to specify the pom to build the module,
mvn clean install -f java-sdk-logging/pom.xml
However, we need to add a separate CI to ensure the tests are passing.
There was a problem hiding this comment.
I would prefer the tests for this module are a separate CI, since it has no dependencies on other modules at all. Even if the tests fail, it should not block the release of other modules.
There was a problem hiding this comment.
Sure, I'll create a separate ci.
| <parent> | ||
| <groupId>com.google.api</groupId> | ||
| <artifactId>java-sdk-logging-parent</artifactId> | ||
| <version>0.1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
I wonder if we want to keep the version name the same as the main project?
There was a problem hiding this comment.
This is a standalone module so I don't think the version should be consistent with the main project and not all modules in this repo share the same version, though I don't feel strongly against it.
@blakeli0 what do you think?
There was a problem hiding this comment.
A followup to this, if we keep this standalone with its own versions, what version should we start with? 0.1.0 seems to indicate unstable, do we want that?
There was a problem hiding this comment.
I think 0.1.0 is fine now since we are still developing it.
We can change the version to 1.0.0 when we want to release the library.
pom.xml
Outdated
| @@ -24,6 +24,7 @@ | |||
| <module>gapic-generator-java-bom</module> | |||
| <module>java-shared-dependencies</module> | |||
| <module>sdk-platform-java-config</module> | |||
| <module>java-sdk-logging</module> | |||
There was a problem hiding this comment.
Does it have to be added to the root pom?
java-sdk-logging/pom.xml
Outdated
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-deploy-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Since it is not part of the parent pom now, do we still have to skip this plugin?
| - name: Install parent module | ||
| run: | | ||
| mvn install -B -ntp -pl gapic-generator-java-pom-parent | ||
| - name: Java Linter |
There was a problem hiding this comment.
In addition to linter, can we add clirr check and enforcer check?
There was a problem hiding this comment.
Sure, I'll add them in a follow up PR.
|
|
A follow up of #3706: - Change the group id to `com.google.cloud` as it is a customer-facing library. - Add clirr and enforcer check in CI.
In this PR: